-
Notifications
You must be signed in to change notification settings - Fork 43
P2: Usage examples moved to appropriate pages #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few important maintenance issues
@@ -1,13 +1,27 @@ | |||
.. _java-usage-count: | |||
.. _java-count: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: per the renaming guidance, leave old anchors in place
Q: will there be redirects for moving these pages around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this tag down to the Count Documents Example: Full File, so that anyone referencing it will still be taking to the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a few small nits!
This ready for tech review. |
In this guide, you can learn how to retrieve a list of distinct values for a | ||
field across a collection by calling the ``distinct()`` method on a | ||
``MongoCollection`` object. Pass the document field name as the first parameter | ||
and the class you want to cast the results to as the second parameter as shown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, it's not a cast, since it's a generic type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to:
...and the class you want to use for the results format as the second parameter...
Let me know what you think
~~~~~~~~~~~~~~~~~ | ||
|
||
The ``watch()`` method optionally takes an **aggregation pipeline** which | ||
consists of an array of **stages** as the first parameter to filter and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider changing to: ".... as the first parameter, which can be used to filter and transform the change event output, as follows:`
ab337fc
to
560672c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One grammar nit remaining, but I'll LGTM based on the technical content.
In this guide, you can learn how to retrieve a list of distinct values for a | ||
field across a collection by calling the ``distinct()`` method on a | ||
``MongoCollection`` object. Pass the document field name as the first parameter | ||
and the class you want to use for the results format as the second parameter as shown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and the class you want to use for the results format as the second parameter as shown | |
and the class you want to use for the results as the second parameter, as shown |
Filter the Events | ||
~~~~~~~~~~~~~~~~~ | ||
|
||
The ``watch()`` method optionally takes an **aggregation pipeline** which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still doesn't read well to my ears. To many "which"s. Can you try to re-word it?
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47267
Staging Links
Self-Review Checklist